Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA - PlayWright Dapps testing #2144

Merged
merged 2 commits into from
Dec 9, 2024
Merged

QA - PlayWright Dapps testing #2144

merged 2 commits into from
Dec 9, 2024

Conversation

eunjisong
Copy link
Contributor

@eunjisong eunjisong commented Dec 9, 2024 •
edited
Loading

Description

  • All the playwright tests .spec.ts are passing with this PR.
  • Next: We need to integrate with mobile now.

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

eunjisong
eunjisong commented Dec 9, 2024
View reviewed changes
packages/core-mobile/e2e/helpers/playwrightSetup.ts
const page = await browser.newPage()
const browser = await chromium.launch({ headless: true })
const context = await browser.newContext({
permissions: ['clipboard-read']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving the initial permission here to copy the QRcode

@eunjisong eunjisong changed the title all dapps testing passing QA - PlayWright Dapps testing Dec 9, 2024
@eunjisong eunjisong marked this pull request as ready for review December 9, 2024 16:40
Any2suited66
Any2suited66 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@Any2suited66 Any2suited66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you have a lot of dapps covered here. if in the future there ends up being too much maintenance we should probably cut back on the number of dapps.

@eunjisong eunjisong merged commit 5a6181b into main Dec 9, 2024
4 checks passed
@eunjisong eunjisong deleted the qa/new-playwright-1205 branch December 9, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Any2suited66 Any2suited66 Any2suited66 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eunjisong @Any2suited66